sublime_terminal icon indicating copy to clipboard operation
sublime_terminal copied to clipboard

Terminal not opening

Open codytooker opened this issue 8 years ago • 8 comments

As of yesterday, randomly Iterm does not open. I removed "iTerm2-v3.sh" from the settings variable and the normal mac terminal does open. Nothing has changed on the system, it just randomly stopped working.

There is also no notice in the sublime terminal. Any insight here.

codytooker avatar Feb 17 '17 15:02 codytooker

Try running the .sh script from your OS X Terminal and see what happens

wbond avatar Feb 17 '17 15:02 wbond

When running the Terminal.sh script from Iterm it opens a new terminal window. When running the Iterm2-vs.sh script nothing happens.

codytooker avatar Feb 20 '17 15:02 codytooker

I'm having the same issue. Still looking into it, I'll report back if I figure out what's causing it.

jonschlinkert avatar Feb 21 '17 22:02 jonschlinkert

ok, I'm not yet sure why this worked, but I was able to get it working by replacing all references to iTerm with iTerm2 in iTerm2-v3.sh.

jonschlinkert avatar Feb 21 '17 22:02 jonschlinkert

@jonschlinkert That's likely an unrelated issue -- can you double check iTerm is named iTerm.app instead of iTerm2.app in your Applications folder?

twolfson avatar Feb 21 '17 22:02 twolfson

edit: sorry, forgot to mention.... I can open a new issue and move this convo there if you want.

That's likely an unrelated issue

Well, yeah I was thinking the same thing - I haven't looked but I was assuming also that the file would have to be named iTerm2. I was also assuming that this might be common, given that the file is for iTerm2, and I didn't manually rename that file, I just installed iTerm2. When I installed iTerm2, it's possible that it initially installed alongside iTerm 1.x, and the file name was auto-incremented or something.

fwiw I've been using this for a while, and it just stopped working within the past couple of weeks. I'm not sure why it worked before... it's entirely possible that I manually patched the iterm2-v3.sh file in the past with the intention of finding a more permanent solution or doing a PR or something and forgot about it.

In any case, given that the file in question is for iTerm2, should we consider implementing logic to check for iTerm or iTerm2? My situation might be somewhat of an edge case, but it happened, and it's possible that it happens to other users.

jonschlinkert avatar Feb 22 '17 00:02 jonschlinkert

I think it's sanest maintenance wise to keep it exclusively to the default that iTerm2 itself provides. Otherwise, we get a bunch of extra logic when someone could easily do what you did (i.e. fork the script) to customize it to their needs.

As you said, if you would like to continue this conversation, then please open a separate thread

twolfson avatar Feb 22 '17 00:02 twolfson

I don't want to continue the conversation.

jonschlinkert avatar Feb 22 '17 02:02 jonschlinkert