sublime_terminal icon indicating copy to clipboard operation
sublime_terminal copied to clipboard

Published 20 hours ago • verified publisher icon wbond

Terminal (OSX).sublime-settings doesn't load on MacOS 10.4 Sierra

Open drbarrett opened this issue 8 years ago • 3 comments

in get_setting: os.name returns 'posix' rather than 'darwin'.

Replacing os.name with sys.platform returns 'darwin'. This change works on MacOS and Linux. I don't have a Windows machine so can't verify the change there.

drbarrett avatar Feb 02 '17 18:02 drbarrett

Ah, nice catch. I think sys.platform should work fine for Windows based on documentation. Be sure to use .startswith('linux') for Sublime Text 2 though:

https://docs.python.org/2/library/sys.html#sys.platform

Would you be interested in submitting a PR?

twolfson avatar Feb 02 '17 20:02 twolfson

Yeah, I'll write one up this evening

drbarrett avatar Feb 02 '17 20:02 drbarrett

This has been patched by @drbarrett in #162 and released in 1.17.0. Thanks again for the bug report and quick PR submission :+1:

twolfson avatar Feb 03 '17 06:02 twolfson