package_control_channel
package_control_channel copied to clipboard
wbond
Add Scenic package
- [x] I'm the package's author and/or maintainer.
- [x] I have have read the docs.
- [x] I have tagged a release with a semver version number.
- [x] My package repo has a description and a README describing what it's for and how to use it.
- [x] My package doesn't add context menu entries. *
- [x] My package doesn't add key bindings. **
- [x] Any commands are available via the command palette.
- [x] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
- [x] If my package is a syntax it doesn't also add a color scheme. ***
- [ ] I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.
This package provides a syntax for the Scenic domain-specific probabilistic programming language, used to model the environments of cyber-physical systems like autonomous vehicles. There are no packages currently providing this functionality in Package Control.
The package is forked from the MagicPython package already in Package Control, since Scenic's syntax is similar to Python's. The MagicPython package didn't have a .gitattributes file, so I assumed one isn't needed here either (I haven't added any images, etc.); please let me know if not.
Was that package meant to be for all those different editors?
If not you should have a look at:
- https://www.sublimetext.com/docs/syntax.html
- https://www.sublimetext.com/docs/scope_naming.html
-
https://github.com/sublimehq/Packages
- and the workflow there to automate testing, also https://www.sublimetext.com/docs/syntax.html#testing
- you can find test examples there in the
./*/tests/syntax_test_*files
FYI: All this will bump requirements to ST4075+, though.
None of those links apply, I think, since this package uses the old .tmLanguage syntax definition format. As I mentioned in my reply to your comment above, my package is really just a variant of the MagicPython package, which is already in Package Control with no Sublime version constraints.
(EDIT: spoke too soon, of course the scope names are relevant; I meant the stuff about the new kind of syntax files.)
Always a bit of a shame to see new syntaxes in that format, but understandable since it's widely supported (or at least somewhat) in other editors. So in general the package looks good. Some images you can remove from the package using .gitattributes, but nothing major.
You do need to tag a release using proper semver numbering (e.g. 1.0.0) though.
Closing due to lack of activity. We can always re-open and continue the review when you're ready for it.
Hello @braver, sorry for the slow reply (was on parental leave!). Is the issue that the tag name needs to be v1.0.0 instead of just v1.0?
Hello @braver, I'm finally getting back around to this. I've added a .gitattributes file and made a v1.1.0 tag (I had made some improvements in the package in the mean time), so hopefully the package is ready to go now.