package_control_channel icon indicating copy to clipboard operation
package_control_channel copied to clipboard

add cyclone sublime package

Open classicwuhao opened this issue 3 years ago • 1 comments

  • [x] I'm the package's author and/or maintainer.
  • [x] I have have read the docs.
  • [x] I have tagged a release with a semver version number.
  • [x] My package repo has a description and a README describing what it's for and how to use it.
  • [x] My package doesn't add context menu entries. *
  • [x] My package doesn't add key bindings. **
  • [x] Any commands are available via the command palette.
  • [x] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • [x] If my package is a syntax it doesn't also add a color scheme. ***
  • [x] I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package supports syntax highlight for Cyclone specification language. https://classicwuhao.github.io/cyclone_tutorial/tutorial-content.html

There are no packages like it in Package Control.

classicwuhao avatar Jun 19 '22 14:06 classicwuhao

update repo based no the review

classicwuhao avatar Jun 28 '22 21:06 classicwuhao

Please have a look at the Scope Naming guide and make sure the scopes specific to your syntax end the short name of your language (in this case .cyclone).

braver avatar Nov 20 '22 20:11 braver

You may also want to try to tag a release without all the additional files. They're not needed for manual installation (people can simply just drop your repo into the Packages dir) and it seems like it trips up the bot here.

braver avatar Nov 20 '22 20:11 braver

Please respond to the feedback to continue the review.

braver avatar Dec 05 '22 15:12 braver

I don't understand why it always report the same error. I have already removed .sublime-package files. Only syntax file exists. Can anyone explain this to me? Thanks

classicwuhao avatar Dec 15 '22 22:12 classicwuhao

You need to tag a new release, package control only looks at the tags in your repo.

braver avatar Dec 17 '22 10:12 braver

Please have a look at the Scope Naming guide and make sure the scopes specific to your syntax end the short name of your language (in this case .cyclone).

Don’t forget about this one.

braver avatar Dec 19 '22 19:12 braver

  • setting
    version: 1.0
    
    is not supported, version: 1 is implied, or set version: 2, compare https://www.sublimetext.com/docs/syntax.html#header
  • you have a typo in the repo name, not sure if you want to republish
  • syntax variables should have non-capturing groups
  • assuming you choose version: 2 for your syntax, pop: true should be pop: 1
  • your base scope should be source.cyclone instead of cyclone
  • the scopes of rules in your contexts should have a .cyclone suffix

jrappen avatar Dec 20 '22 20:12 jrappen

Please let us know if you want to re-open this PR and continue the review.

braver avatar Jan 16 '23 19:01 braver