package_control_channel icon indicating copy to clipboard operation
package_control_channel copied to clipboard

Add RegexMatch package

Open mercurykd opened this issue 3 years ago • 8 comments
trafficstars

  • [x] I'm the package's author and/or maintainer.
  • [x] I have have read [the docs][1].
  • [x] I have tagged a release with a [semver][2] version number.
  • [x] My package repo has a description and a README describing what it's for and how to use it.
  • [x] My package doesn't add context menu entries. *
  • [x] Any commands are available via the command palette.
  • [x] If my package is a syntax it doesn't also add a color scheme. ***

My package is Testing regular expressions

There are no packages like it in Package Control.

mercurykd avatar May 04 '22 11:05 mercurykd

Very interesting package idea! Some questions:

  • Do you really need the keybinding?
  • The feedback UI seems a bit limiting for larger regexes with more capture groups. Maybe you could utilize the output panel for more details about the matches?
  • Are you fully highlighting the regex, like with escape sequences etc?

braver avatar May 06 '22 19:05 braver

  • Do you really need the keybinding?

no

  • The feedback UI seems a bit limiting for larger regexes with more capture groups. Maybe you could utilize the output panel for more details about the matches?

good idea

  • Are you fully highlighting the regex, like with escape sequences etc?

didn't really understand the question

mercurykd avatar May 06 '22 19:05 mercurykd

add license and delete keybinding

mercurykd avatar May 06 '22 20:05 mercurykd

add:

  • explain in panel
  • display groups like /()/

mercurykd avatar May 09 '22 13:05 mercurykd

removed global variables color scheme patch redundant events removed

mercurykd avatar May 15 '22 11:05 mercurykd

Are you fully highlighting the regex, like with escape sequences etc?

didn't really understand the question

If you look at a regex in say Python, sequences, certain characters and escapes are highlighted with different colors. In your package it's just a string. Would be nice to have syntax highlighting for the regex. Since you probably only support Python regexes anyway (which is something you might want to clarify in your readme, the underlying regex engine can be quite relevant), you might be able to apply the same syntax in this context?

braver avatar Jun 05 '22 12:06 braver

If you look at a regex in say Python, sequences, certain characters and escapes are highlighted with different colors

do you mean highlight the regex pattern itself? image

mercurykd avatar Jun 05 '22 14:06 mercurykd

yes!

braver avatar Jun 24 '22 19:06 braver

Well, consider those improvements in your own time. I think we should just ship it now as is.

braver avatar Nov 20 '22 15:11 braver