package_control icon indicating copy to clipboard operation
package_control copied to clipboard
verified publisher icon wbond

Small issues with theme unsetting

Open FichteFoll opened this issue 10 years ago • 2 comments

In the rare case that you uninstall a package that provides an additional .sublime-theme file which complements another one with the same name, e.g. by providing icons, Package Control will reset the theme file to "Default.sublime-theme" anyway. Maybe PC could check for sublime.find_resource("ThemeName.sublime-theme") ~~(or os.walk for ST2)~~ before unsetting.

Repro

  1. Install https://packagecontrol.io/packages/Material%20Theme and https://packagecontrol.io/packages/Material%20Theme%20-%20White%20Panels
  2. Set `"theme": "Material-Theme.sublime-theme" and restart
  3. Remove "Material Theme - White Panels" package

Another small issue I have is that package control does not suggest a restart when doing this, but only when the package was updated. Similar: #961.

FichteFoll avatar Jun 25 '15 23:06 FichteFoll

The problem is it to be rather unclear, which of the packages contains the main theme, which is required.

deathaxe avatar Sep 19 '22 19:09 deathaxe

A probably safe check would be the theme file's size as it is unlikely for an additional theme file to contain more characters than the original. This becomes a problem when the theme is extending another, however.

FichteFoll avatar Sep 20 '22 07:09 FichteFoll