package_control
package_control copied to clipboard
wbond
Warn about theme update before deactivating it
It can be quote annoying when you start ST, it suddenly it looks all messed up and you have no idea why.
Package control does warn about this, but it only does so after updating the theme:
Shouldn't this warning appear before disabling the active theme?
Showing this exact warning before the upgrade might cause the user to resart ST before the update is finished. It would have to be a different warning and the current one would still have to remain so that the user waits until all packages have been upgraded, meaning it has to show two messages. I'm not sure if that might be too many, but I think it's better than currently.
Actually, before I figured out why this was happening, I thought ST had some weird inconsistency in loading themes and thus restarted ST immediately after the theme broke. That surely caused the update to fail.
Having multiple prompts when a theme upgrade happens does not seem user friendly. Especially if it happens frequently.
Did the default theme look corrupted, or did you just think something was weird because the theme switched back to the default?
It wasn't that bad, but I have a dark theme and dark color scheme, then the sidebar suddenly turned all white. I'm not sure if it was actually corrupted or just looked weird.
This is my default look:
This is how it looks after removing the theme from the settings, I'm not sure if that's how it looked while updating. It looks a bit weird IMO, but it's not broken:
This is where I used to restart ST3 because I thought it failed to load the theme, or I went to settings and manually set the theme key.
And this is how it looks after switching back to my theme, and how it looked after updating, which is obviously broken:
Maybe - when there's an update for the active theme - you could ask the user to update theme now or to do it later?