asn1crypto icon indicating copy to clipboard operation
asn1crypto copied to clipboard

Add support for RFC3779 X509 extensions for IPs and AS-IDs

Open niklbird opened this issue 3 years ago • 5 comments

niklbird avatar Nov 11 '22 13:11 niklbird

Looks like you need to fix some linting errors

wbond avatar Nov 11 '22 13:11 wbond

Looks like you need to fix some linting errors

Thank you! I fixed them now :)

niklbird avatar Nov 14 '22 11:11 niklbird

Hey :) Is there anything still missing that you need?

niklbird avatar Dec 06 '22 14:12 niklbird

Could you rebase this on master?

wbond avatar Aug 23 '23 11:08 wbond

Thanks for taking the time to add these.

Overall it looks good. The one style change I would request is that for this project we use under_score notation instead of camelCase for the ASN.1 field names. In other words, things like addressRange should be address_range.

wbond avatar Aug 23 '23 18:08 wbond