asn1crypto icon indicating copy to clipboard operation
asn1crypto copied to clipboard

Add tests to reproduce a ValueError when x500UniqueIdentifier is of type UTF8String

Open vxgmichel opened this issue 3 years ago • 5 comments
trafficstars

Add tests to reproduce issue #228

vxgmichel avatar Oct 18 '22 15:10 vxgmichel

Could you rebase this on master?

wbond avatar Aug 23 '23 11:08 wbond

Could you rebase this on master?

Sure, I allowed edits by maintainers :+1:

vxgmichel avatar Aug 23 '23 11:08 vxgmichel

A few things:

  1. The code doesn't pass linting
  2. purest isn't used on this project
  3. The test harness from this project requires specifying a new test class in test_classes() of tests/__init__.py, so currently these tests aren't run, and why it wasn't obvious that pytest isn't supported

wbond avatar Aug 23 '23 16:08 wbond

@wbond here you go, all your points should be addressed : 3758f73 :)

vxgmichel avatar Aug 24 '23 11:08 vxgmichel

Thank you @wbond for fixing #268

And yes this is also a shameless ping for issue #228 :)

vxgmichel avatar Nov 07 '23 18:11 vxgmichel