DnCNN-tensorflow icon indicating copy to clipboard operation
DnCNN-tensorflow copied to clipboard

Performance issue in /model.py (by P3)

Open DLPerf opened this issue 3 years ago • 2 comments

Hello! I've found a performance issue in /model.py: .batch(batch_size)(here) should be called before .map(im_read, num_parallel_calls=num_parallel_calls)(here) and .map(get_patches_fn, num_parallel_calls=num_parallel_calls)(here), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function get_patches_fn called in .map(get_patches_fn, num_parallel_calls=num_parallel_calls) whether to be affected or not to make the changed code work properly. For example, if get_patches_fn needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 29 '21 13:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf

Good suggestion.

sdlpkxd avatar Oct 12 '23 06:10 sdlpkxd