[express-session] Can't keep session values with default options.

[monaka]

In @nest-middlewares/express-session, always new session object is created per routing when options was applied.

https://github.com/wbhob/nest-middlewares/blob/077baf8296b61684b273d9c8689d985186669ba6/packages/express-session/index.ts#L15-L16

And express-session creates new instance of MemorySession if option.store wasn't specified.

https://github.com/expressjs/session/blob/10607bdb780204b91a8cf90e4ce27726619b8285/index.js#L99-L100

So the app can't keep values in the session.

I suspect the value of expressSession should be cached in the class ExpressSessionMiddleware.

[monaka]

Workaround for now: setting sessionStore explicitly. Like

export class ApiModule {
  private sessionStore = new MemoryStore();

  configure(consumer: MiddlewareConsumer) {
    ExpressSessionMiddleware.configure({
      store: this.sessionStore,

[wbhob]

can you open a PR? I didn't know it worked like this. I'd be happy to merge

[ShareQiu1994]

I had the same problem， I have the same problem. Each session cannot be saved

my code

     ExpressSessionMiddleware.configure({
      secret: 'liubf', 
      name: 'nest',
      resave: false,
      saveUninitialized: false, 
      rolling: true, 
      cookie: {
        maxAge: 60 * 1000 * 30, 
      },
    });

[ShareQiu1994]

[wbhob]

I'd be glad to accept a PR for this issue

[vip30]

export class ExpressSessionMiddleware implements NestMiddleware {

    // DELETE THESE LINES IF MIDDLEWARE DOES NOT TAKE OPTIONS
    public static configure(opts: expressSession.SessionOptions) {
        this.options = opts;
    }

    private static options: expressSession.SessionOptions;
    private handler: Express.RequestHandler;
    
    private getHandler() {
        if (this.handler) return this.handler;
        if (ExpressSessionMiddleware.options) this.handler = expressSession(ExpressSessionMiddleware.options);
        else this.handler = expressSession();
        return this.handler;
    }

    public use(req: any, res: any, next: any) {
        this.getHandler()(req, res, next);
    }
}

Seems modify the function to singleton will work I am fine to make a pr for this changes

[wbhob]

Fixed in 10.0.1