Nemo.jl icon indicating copy to clipboard operation
Nemo.jl copied to clipboard

convert from fmpq_mat to Matrix{Rational}

Open cossio opened this issue 9 years ago • 2 comments

cossio avatar Sep 12 '16 15:09 cossio

Thanks again! In both these pull requests, it makes sense to write a test which converts to a Julia matrix and then back again and checks if the result is the same.

You would add a new test function for this in Nemo/test/flint/fmpq_mat-tests.jl, etc.

This way, Travis-CI would be testing something nontrivial.

Also, you might want to add a section on conversions in doc/src/matrix.jl You'd need a docstring on the actual functions. (We can run the documentation parser once the docs exist.)

wbhart avatar Sep 12 '16 16:09 wbhart

Thanks. I will take a look at the tests and the docs tomorrow.

cossio avatar Sep 12 '16 19:09 cossio