William Bradford Clark
William Bradford Clark
- Rebased on latest master - Also use FQCNs in roles/ - A couple additional commits to appease ansible-lint This is now ready for review
> Is there a known test that checks and ensures FQCN is used that can be added to a Github Action? The closest I can find is https://ansible-lint.readthedocs.io/en/latest/rules/fqcn-builtins/ That will...
@ehelms @evgeni @ekohl Thanks for the comments. Please let me know if there is any additional feedback.
> I can follow @evgeni's reasoning what `fqcn-builtins` is a very strict rule with minimal benefit. Have you considered disabling the lint rule instead? My preference is to default to...
Pushed a fix of a bug I introduced while appeasing the linter. After re-testing it, it is once again working.
@hao-yu the approach looks nice. do you have bandwidth to finish it at the moment?
I'm running some live tests on this in my devel environment. Will do another review when that is complete. (If anyone else is interested, I had to rebase this on...
My sincere apologies for the delay in finishing this review. After thoroughly testing this in my development environment, I came up with a few recommendations to slightly improve the UX...
Closing in favor of newer attempts at the issue.
> Regarding `cfg` I can agree in principle, but that's the name used in [hydra docs](https://hydra.cc/docs/tutorials/basic/your_first_app/simple_cli/) and I'm used to that convention now. What do you think? I guess it...