starphleet icon indicating copy to clipboard operation
starphleet copied to clipboard

Support docker images

Open fearphage opened this issue 6 years ago • 11 comments

This seems like a relatively straight forward process aside from pulling down the images from a central repository (dockerhub?).

  • [ ] Add a flag/line in orders to trigger docker mode
  • [ ] Add docker-ce to /scripts/packages
  • [ ] Ignore logs (for now?) since docker contains/maintains them
  • [ ] Figure out how this could work for jobs or worst-case disable the functionality for jobs

Question

Would it be better/more beneficial to fork the startup, stop, etc. scripts to be able to control docker containers OR just make devs use the raw docker commands instead? I'm in favor of the latter, but I do see the benefits of a unified way to do all the things.

Benefits

  • Easy image construction - built locally so super easy to debug.
  • Ability to use base community-supported images (node, python, etc).
  • self-contained logs so you don't have to grep/search/cat/tail

Why

Logging/debugging applications has really been a tough part of getting up to speed with the Starphleet process for me. This side steps much of that while providing additional benefits.

Considerations

I tried upgrading the version of lxc used to get the native support for docker images, but all of the Starphleet scrips are tightly coupled to the version we're using so it doesn't seem like a worthwhile route to explore honestly.

Thoughts, concerns, etc?

fearphage avatar Apr 10 '18 20:04 fearphage