Build error against libgps 3.24

[yuvadm]

Similar to #357 build fails when building against libgps 3.24

[ 37%] Building C object src/CMakeFiles/direwolf.dir/dwgpsd.c.o
src/direwolf/src/dwgpsd.c:68:2: error: #error libgps API version might be incompatible.
   68 | #error libgps API version might be incompatible.
      |  ^~~~~
make[2]: *** [src/CMakeFiles/direwolf.dir/build.make:1014: src/CMakeFiles/direwolf.dir/dwgpsd.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:538: src/CMakeFiles/direwolf.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

[wb2osz]

Which version of direwolf is this? Try using the "dev" branch.

[yuvadm]

@wb2osz sorry I forgot to mention this, I am already on dev branch, head commit d11bd6f

[meltdown03]

I changed this line to a #warning instead of an error and rebuilt it. https://github.com/wb2osz/direwolf/blob/7d3c1d100ea38605bf5d11459f5a678be99fffab/src/dwgpsd.c#L64

[yuvadm]

@meltdown03 does the build work properly? No breaking changes in gpsd?

[wb2osz]

Sometimes a major API number change includes incompatibilities with previous versions. It might compile successfully but not operate properly without additional source code changes. You will find conditional compilation, in several places, dealing with those incompatible API changes. Did you test for correct operation?

[meltdown03]

No, I didn't have a chance to test it yet.

On Wed, Jun 29, 2022, 10:25 AM wb2osz @.***> wrote:

Sometimes a major API number change includes incompatibilities with previous versions. It might compile successfully but not operate properly without additional source code changes. You will find conditional compilation, in several places, dealing with those incompatible API changes. Did you test for correct operation?

— Reply to this email directly, view it on GitHub https://github.com/wb2osz/direwolf/issues/402#issuecomment-1170121383, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPBQCA5SGEJR6I6TD63F5LVRRTIJANCNFSM5ZG2BBVA . You are receiving this because you were mentioned.Message ID: @.***>

[yuvadm]

There's a comment on Arch Linux AUR that confirms no regression with new gpsd versions https://aur.archlinux.org/packages/direwolf-git#comment-872500

[wb2osz]

This has been tested on gpsd versions up through 3.25. Closing.