wazuh-puppet icon indicating copy to clipboard operation
wazuh-puppet copied to clipboard

Change fail to warn on wazuh::agent

Open nick-fox opened this issue 4 years ago • 2 comments

Wazuh agent may be enforced across a wide range of servers in an Org.

It would be nice if the wazuh::agent were to warn, rather than fail if OS constraints were not met. https://github.com/wazuh/wazuh-puppet/blob/51fe0e9f99b2c56bc49d936ebfdb884f5bbcbe6a/manifests/params_agent.pp#L527

For example, CentOS 6 has recently reached EOL and some users may have had to convert CentOS 6 to CloudLinux 6. Any system is now running CloudLinux 6 would fail to run puppet at all.

nick-fox avatar Jan 22 '21 10:01 nick-fox

Hello @nick-fox,

It would be nice if the wazuh::agent were to warn, rather than fail if OS constraints were not met. For example, CentOS 6 has recently reached EOL and some users may have had to convert CentOS 6 to CloudLinux 6.

I see your point here. I also think it is a good idea to replace fails with warnings so we don't exclude systems that could be compatible even if they are not considered in the distributions officially supported by wazuh-puppet.

Note: Puppet built-in warning function.

As soon as our workflow allows us we will be hands-on with this fix. Thank you for your contribution Nick, we appreciated it!

-JP

Zenidd avatar Jan 27 '21 10:01 Zenidd

Hello, has there been any update on this? I am getting this error when trying to deploy on RHEL 9. We are using the module version 4.3.10.

aknight0587 avatar Feb 27 '23 20:02 aknight0587