wazuh-docker icon indicating copy to clipboard operation
wazuh-docker copied to clipboard

wazuh-dashboard docker entrypoint script should use exec when starting the application

Open mlaaksonen-csc opened this issue 1 year ago • 1 comments

Currently wazuh-dashboard docker entrypoint script starts the actual application without exec'ing which has the side effect that any signals (HUP, TERM, INT) sent to the container are not passed to the application.

The fix is pretty trivial, just add exec in front of the last command (actual application to be run) in the entrypoint.sh script:

--- a/build-docker-images/wazuh-dashboard/config/entrypoint.sh
+++ b/build-docker-images/wazuh-dashboard/config/entrypoint.sh
@@ -17,4 +17,5 @@ echo $DASHBOARD_PASSWORD | $INSTALL_DIR/bin/opensearch-dashboards-keystore add o
 
 /wazuh_app_config.sh $WAZUH_UI_REVISION
 
-/usr/share/wazuh-dashboard/bin/opensearch-dashboards -c /usr/share/wazuh-dashboard/config/opensearch_dashboards.yml
\ No newline at end of file
+exec /usr/share/wazuh-dashboard/bin/opensearch-dashboards -c /usr/share/wazuh-dashboard/config/opensearch_dashboards.yml
+

mlaaksonen-csc avatar Jul 17 '23 11:07 mlaaksonen-csc

Hello @mlaaksonen-csc

Thank you very much for the correction, we will review it to add it in a future version.

I still encourage you to create your own PR to be able to add your change to the repository. If you are interested in adding your own commit, I recommend that you do it on branch 4.4 of our repository and sign your commit.

vcerenu avatar Jul 18 '23 14:07 vcerenu