wazuh-dashboard-plugins icon indicating copy to clipboard operation
wazuh-dashboard-plugins copied to clipboard

Fix inventory table fullscreen styles

Open asteriscos opened this issue 9 months ago • 3 comments

Description

This pull request fixes vulnerabilities inventory table fullscreen styles and restores dev tools console font size to 4.7.x Wazuh dashboard version dev tools font size (14.5px).

Issues Resolved

Closes #6645

Evidence

Vulnerabilities inventory table full screen

** Docked navigation bar ** image

** Undocked navigation bar ** image

Dev tools font size

image

Test

Vulnerabilities inventory table full screen

  • Generate at least 1000 vulnerability events

  • Go to Vulnerabilities / Inventory

  • With docked side navigation bar

    • Test all pages size: 20, 50, 100
    • Whenever it's needed, the table should have a vertical scrollbar the size of the table container
    • The width should adjust to the horizontal available space excluding the side navigation bar
Docked test example

Peek 2024-05-08 13-33

  • Without docked side navigation bar
    • Test all pages size: 20, 50, 100
    • Whenever it's needed, the table should have a vertical scrollbar the size of the table container
    • The width should adjust to the horizontal available space to all the viewport width
Undocked test example

Peek 2024-05-08 13-31

Dev tools font size

  • Check the dev tools console font size is 14.5px

Check List

  • [x] All tests pass
    • [x] yarn test:jest
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

asteriscos avatar May 08 '24 11:05 asteriscos

Test

Vulnerabilities inventory table full screen

  • Generate at least 1000 vulnerability events

  • Go to Vulnerabilities / Inventory

  • 🟢 With docked side navigation bar

    • Test all pages size: 20, 50, 100
    • Whenever it's needed, the table should have a vertical scrollbar the size of the table container
    • The width should adjust to the horizontal available space excluding the side navigation bar
Docked test

Uploading Screen Recording 2024-05-08 at 10.38.50 AM.mov…

  • 🟢 Without docked side navigation bar
    • Test all pages size: 20, 50, 100
    • Whenever it's needed, the table should have a vertical scrollbar the size of the table container
    • The width should adjust to the horizontal available space to all the viewport width
Undocked test

Uploading Screen Recording 2024-05-08 at 10.39.51 AM.mov…

🟡 Dev tools font size

  • Check the dev tools console font size is 14.5px

in safari has 14px

image

yenienserrano avatar May 08 '24 13:05 yenienserrano

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4234 / 34727 )
Branches 8.28% ( 1928 / 23280 )
Functions 11.58% ( 959 / 8277 )
Lines 12.36% ( 4122 / 33330 )

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]