wazuh-dashboard-plugins icon indicating copy to clipboard operation
wazuh-dashboard-plugins copied to clipboard

Implement embeddable dashboard on HIPAA

Open Desvelao opened this issue 1 year ago • 3 comments

Description

This pull request replaces the Dashboard tab on HIPAA application.

Issues Resolved

#6507

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

[Provide instructions to test this PR]

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

Desvelao avatar Mar 14 '24 07:03 Desvelao

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

Main plugin code coverage (Jest) test % values
Statements 10.8% ( 3751 / 34720 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.5% ( 870 / 8284 )
Lines 10.95% ( 3645 / 33277 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

Test

Go to HIPAA > Dashboard:

  • [x] Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
Details image
  • [x] The visualizations have to be updated according to the filters applied in the searchbar.
Details image
  • [x] The visualizations have to be updated when a search is performed in the searchbar.
Details image
  • [x] If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
Details image
  • [x] If there is SampleData, the corresponding SampleData message must appear.
Details image
  • [x] If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Details image
  • [x] Check filter behavior with respect to hide alerts, allow agents and filter order.
Details image

Go to HIPAA > Controls

  • [x] Check the requirements filters on the on the left side filters the requirements on the right side.
Details image
  • [x] 🟡 Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected.
Details image image

the flyout is inheriting the filters that the global search bar has but it is not showing it.

image
  • [x] The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
Details image
  • [x] In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
Details image image image
  • [x] The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Details image image image

yenienserrano avatar May 10 '24 13:05 yenienserrano

Test

Go to HIPAA > Dashboard:

:green_circle: Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

Details

image

:green_circle: The visualizations have to be updated according to the filters applied in the searchbar.

Details

image

:green_circle: The visualizations have to be updated when a search is performed in the searchbar.

Details

image

:green_circle: If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

Details

image

:green_circle: If there is SampleData, the corresponding SampleData message must appear.

Details

image

:green_circle: If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Details

image

:green_circle: Check filter behavior with respect to hide alerts, allow agents and filter order.

Details

image

Go to HIPAA > Controls

:green_circle: Check the requirements filters on the on the left side filters the requirements on the right side.

Details

image

:green_circle: Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected.

Details

image

:green_circle: The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.

Details

image

:green_circle: In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement

Details

Peek 2024-05-13 11-46

Peek 2024-05-13 11-46

:green_circle: The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Details

Peek 2024-05-13 11-47

Peek 2024-05-13 11-48

asteriscos avatar May 10 '24 17:05 asteriscos

@asteriscos I was reviewing the finding about the The rule tab has no information about the rule, and there is not a built-in rule with the specified ID 479. I think the alert could be generated through the sample data. Could you check it?

Desvelao avatar May 13 '24 06:05 Desvelao

Yes, you are right. I re-tested it and it seems it was because of the sample data. Aparently it created alerts with rule IDs non-existent.

asteriscos avatar May 13 '24 09:05 asteriscos