wazuh-dashboard-plugins
wazuh-dashboard-plugins copied to clipboard
Implement embeddable dashboard on GDPR
Description
This pull request replaces the Dashboard
and adapts the Controls
tab on the GDPR application.
Other changes:
- Fix repeated request on Regulatory compliance > Controls > flyout and MITRE ATT&CK > Framework > flyout
Issues Resolved
#6505
Evidence
Test
Go to GDPR > Dashboard:
Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking. The visualizations have to be updated according to the filters applied in the searchbar. The visualizations have to be updated when a search is performed in the searchbar. If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered. If there is SampleData, the corresponding SampleData message must appear. If an agent is pinned, the views must be updated and changed to the agent view, if applicable. Check filter behavior with respect to hide alerts, allow agents and filter order.
Go to GDPR > Controls Check the requirements filters on the on the left side filters the requirements on the right side Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled. In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Check List
- [ ] All tests pass
- [ ]
yarn test:jest
- [ ]
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [x] Update CHANGELOG.md
- [x] Commits are signed per the DCO using --signoff
Wazuh Core plugin code coverage (Jest) test | % | values |
---|---|---|
Statements | 45.37% | ( 397 / 875 ) |
Branches | 41.31% | ( 157 / 380 ) |
Functions | 43.83% | ( 135 / 308 ) |
Lines | 45.61% | ( 395 / 866 ) |
Wazuh Check Updates plugin code coverage (Jest) test | % | values |
---|---|---|
Statements | 76.44% | ( 172 / 225 ) |
Branches | 58.65% | ( 61 / 104 ) |
Functions | 61.7% | ( 29 / 47 ) |
Lines | 76.44% | ( 172 / 225 ) |
Main plugin code coverage (Jest) test | % | values |
---|---|---|
Statements | 10.8% | ( 3751 / 34716 ) |
Branches | 7.27% | ( 1653 / 22731 ) |
Functions | 10.5% | ( 870 / 8282 ) |
Lines | 10.95% | ( 3645 / 33273 ) |
I found repeated filters on the discover table of Controls
> flyout
. This is happening in all the apps related to regulatory compliance and MITRE ATT&CK.
This should not be a reason to block the pull request. We will review this problem later.
Test 🟢
Dashboard
https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/0388b792-5237-431d-9a0c-f90685ea1f12
Controls
https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/76139e8a-5861-4abe-8430-5fd9a0b9117d
CR :green_circle:
Test :green_circle:
Dashboard
:green_circle: Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
Details
:green_circle: The visualizations have to be updated according to the filters applied in the searchbar.
Details
:green_circle: The visualizations have to be updated when a search is performed in the searchbar.
Details
:green_circle: If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
Details
:green_circle: If there is SampleData, the corresponding SampleData message must appear.
Details
:green_circle: If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Details
:green_circle: Check filter behavior with respect to hide alerts, allow agents and filter order.
Details
Hide manager alerts: false
Hide manager alerts: true
Controls
Go to PCI DSS > Controls
:green_circle: Check the requirements filters on the on the left side filters the requirements on the right side
Details
:green_circle: Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
Details
:green_circle: In the details flyout click on the show on dashboard and events links, they should display these tabs with a filter related to the selected requirement
Details
Dashboard link
Events link
:green_circle: The link on the flyout table should redirect to Endpoint Summary and Rules respectively