wazuh-dashboard-plugins icon indicating copy to clipboard operation
wazuh-dashboard-plugins copied to clipboard

Implement embeddable dashboard on GDPR

Open Desvelao opened this issue 11 months ago • 4 comments

Description

This pull request replaces the Dashboard and adapts the Controls tab on the GDPR application.

Other changes:

  • Fix repeated request on Regulatory compliance > Controls > flyout and MITRE ATT&CK > Framework > flyout

Issues Resolved

#6505

Evidence

image image image

Test

Go to GDPR > Dashboard:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking. The visualizations have to be updated according to the filters applied in the searchbar. The visualizations have to be updated when a search is performed in the searchbar. If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered. If there is SampleData, the corresponding SampleData message must appear. If an agent is pinned, the views must be updated and changed to the agent view, if applicable. Check filter behavior with respect to hide alerts, allow agents and filter order.

Go to GDPR > Controls Check the requirements filters on the on the left side filters the requirements on the right side Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled. In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Check List

  • [ ] All tests pass
    • [ ] yarn test:jest
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

Desvelao avatar Mar 13 '24 14:03 Desvelao

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

Main plugin code coverage (Jest) test % values
Statements 10.8% ( 3751 / 34716 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.5% ( 870 / 8282 )
Lines 10.95% ( 3645 / 33273 )

github-actions[bot] avatar Apr 15 '24 09:04 github-actions[bot]

I found repeated filters on the discover table of Controls > flyout. This is happening in all the apps related to regulatory compliance and MITRE ATT&CK.

image

This should not be a reason to block the pull request. We will review this problem later.

Desvelao avatar May 08 '24 08:05 Desvelao

Test 🟢

Dashboard

https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/0388b792-5237-431d-9a0c-f90685ea1f12

Controls

https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/76139e8a-5861-4abe-8430-5fd9a0b9117d

JuanGarriuz avatar May 10 '24 12:05 JuanGarriuz

CR :green_circle:

Test :green_circle:

Dashboard

:green_circle: Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

Details

Peek 2024-05-13 12-49

:green_circle: The visualizations have to be updated according to the filters applied in the searchbar.

Details

Peek 2024-05-13 12-50

:green_circle: The visualizations have to be updated when a search is performed in the searchbar.

Details

Peek 2024-05-13 12-52

:green_circle: If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

Details

image

:green_circle: If there is SampleData, the corresponding SampleData message must appear.

Details

image

:green_circle: If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Details

Peek 2024-05-13 12-53

:green_circle: Check filter behavior with respect to hide alerts, allow agents and filter order.

Details

Hide manager alerts: false

image

Hide manager alerts: true

image

Controls

Go to PCI DSS > Controls

:green_circle: Check the requirements filters on the on the left side filters the requirements on the right side

Details

image

:green_circle: Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.

Details

image

:green_circle: In the details flyout click on the show on dashboard and events links, they should display these tabs with a filter related to the selected requirement

Details

Dashboard link

Peek 2024-05-13 13-06

Events link

Peek 2024-05-13 13-06

:green_circle: The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Details

Agent

Peek 2024-05-13 13-08

Rule

Peek 2024-05-13 13-09

asteriscos avatar May 13 '24 11:05 asteriscos