wazuh-dashboard-plugins icon indicating copy to clipboard operation
wazuh-dashboard-plugins copied to clipboard

Agent dissapear from url when unpin agent

Open CPAlejandro opened this issue 2 years ago • 4 comments

Hi guys,

With this PR we solve that the agent persist in the URL when you unpinned it.

To test it:

  • Check if in some section, when you unpin an agent, the agent persist in the URL.

Closes #3564

CPAlejandro avatar Sep 14 '21 14:09 CPAlejandro

Jest Test Coverage % values
Statements 3.78% ( 1348 / 35678 )
Branches 1.45% ( 407 / 28080 )
Functions 2.58% ( 222 / 8602 )
Lines 3.83% ( 1305 / 34103 )

github-actions[bot] avatar Sep 22 '21 14:09 github-actions[bot]

Incompatibility detected

This PR has 4.3-7.10 as base branch, but solves an issue related to the Office365 module which is not yet merged into 4.3-7.10. Instead, this PR should be merged into the feature/Office365, which contains the Office365 module implementation and splits from '4.3-7.10' as well.

AlexRuiz7 avatar Oct 19 '21 14:10 AlexRuiz7

thought: I'm not sure it's a good idea to include the proposed fix. It looks unfancy and adds technical debt. Maybe we could see if there is a better solution.

Desvelao avatar Oct 28 '21 11:10 Desvelao

LGTM :heavy_check_mark:

yenienserrano avatar Dec 16 '21 20:12 yenienserrano