webpack-subresource-integrity icon indicating copy to clipboard operation
webpack-subresource-integrity copied to clipboard

Published 20 hours ago • verified publisher icon waysact

Refactoring, generate ESM

Open jscheid opened this issue 3 years ago • 1 comments

  • No functional changes
  • Generate ESM modules
  • Upgrade dependencies
  • Remove runtime dependency on typed-assert
  • Restructure for cleaner main directory
  • Improve code readability
  • Add more tests

jscheid avatar Mar 28 '22 07:03 jscheid

Hi @MLoughry, I'd like to request your review here because I've made some fairly extensive changes to your feature: 9a9ffab1d5124784e78976f6178d4dc57ee84f8e and 20a2d7a35610d71416f3f2a9936523dadeb603ce. This was mainly to make CodeClimate happy, and even if I don't agree with all of its mandates (for example, I thought your use of nested functions was perfectly fine) I do think it's a slight improvement overall. Let me know what you think.

Thanks to the typings and test coverage I'm fairly confident that I didn't break anything but you might want to check by running it against your product.

Feel free to provide feedback on the rest of the changes as well, but don't feel obliged. Thanks!

jscheid avatar Mar 28 '22 07:03 jscheid