Wayne Werner
Wayne Werner
Taking a look at this right now - I have a question about the test that I want to confirm real quick.
FWIW, I liked that signal/timeout approach so much I opened a PR to turn it into a test fixture: https://github.com/saltstack/salt/pull/62910 You can see how to use it in https://github.com/saltstack/salt/compare/master...waynew:salt:engine-scripts-tests?expand=1
@ipaqmaster are you interested in adding the tests and getting this merged in?
@Ch3LL I probably won't be able to tackle this before mid Nov/Dec, so if you get to it before that, feel free to take it on!
@litnimax Great talk at SaltConf! Glancing at this - I wonder if changing ``` File "/usr/local/lib/python3.7/site-packages/salt/crypt.py", line 510, in __key opts["master_uri"], # master ID KeyError: 'master_uri' ``` to `opts.get('master_uri')` would...
The way I got out of this was actually by connecting to the device via my phones BT, then I unpaired, and the watchy failed and returned back to the...
☝️ Basically you decide on a testing philosophy. Testing is all about trade-offs. You can test things narrowly or broadly, but at some point you have boundaries beyond which you...
Closes #41
Hm. I didn't notice that there were quite a few non-pip installable dependencies. I'm not sure what the best way is to handle that sort of thing.
Hey @pradyunsg we finally got all the stars aligned and I was able to get this updated. Here's what the new changes look like: **Collapsed**  **Expanded**  Let me...