Wayne Van Son

Results 140 comments of Wayne Van Son

@baptisteArno Join the discord is where there's chatter happening https://discord.gg/gcffYWHDyC

I spoke with a team member in the Discord and they mentioned that windows tests are flaky, even in main. That's why it's marked as ready for review.

> Is this still in limbo with flaky Windows tests? My team is chomping at the bit to start using this. 🥺 I'll update the branch and see if there...

> Just to be clear, is this unrelated to https://tinylibs.github.io/tinybench/interfaces/FnOptions.html#beforeeach and https://tinylibs.github.io/tinybench/interfaces/FnOptions.html#aftereach which allows running code in every iteration that is not included in the total time? > > The...

> > So you're concerned that the current implementation of our Vitest hooks will are part of the execution time? I think it would in it's current state and I...

Benchmarks being reimagined - I'll close this.

Yes @arv, github.com/vitest-dev/vitest/discussions/7850 I've also created this package to run tests as benchmarks which is currently in development. https://github.com/waynevanson/vitest-runner-benchmark

Thanks for the feedback @DaniGuardiola! ## Notes 1. To run benchmarks, the command is `vitest bench`, which sets env variable `MODE="bench"` and only runs `bench` callbacks, throwing when `test` is...

Not sure we could get it to work with vite directly unless we add a new entry like `rollup-preset-solid/vite`. Not a big issue, happy to close if it's out of...