Long press resolution slider favorite selection cycle might be triggered inadvertently

[schlomo]

Using BetterDisplay Pro Version 2.3.3 Build 29731

... and more

The Display Mode submenu is cycling like shown in this video: https://github.com/waydabber/BetterDisplay/assets/101384/92c5d760-0041-401b-9dbc-1900578f03c8

No idea why, to be honest. Could this be a bug?

[waydabber]

Wow, this does not look good, but have no idea how this could happen or how to recreate the issue. :). Does this happen always or was it a one time occurrence?

[schlomo]

I have this for a while already.

[waydabber]

Very interesting. i see the slider animated as well. Is that the case? Normally if you hold the mouse button over the resolution slider, you can toggle favorites. It's like as if somehow a constant mouse press is being detected by the app.

Do you use maybe some kind of third party app or accessibility setting that might have an effect like that?

[schlomo]

No, and I don't observe unexpected mouse clicks anywhere or anytime else

[waydabber]

But do you see the resolution slider being animated and favorite numbers changing? Does this happen after you restart the app? Somehow the slider acts as if there was a constant mouse down without mouse up. Not sure why though.

[schlomo]

Yes, I see the resolution slider changing.

It happened after I restart BetterDisplay and toggle the Display Notch option on and off a few times.

https://github.com/waydabber/BetterDisplay/assets/101384/184a19d4-e7d2-4c4a-9ac9-d5013b2d8499

[waydabber]

Hmm. All right. I'll try to recreate this issue, so far I could not, no matter how I toggle the notch. :)

[waydabber]

It will take some time for me to figure out what's wrong, I did not encounter such an issue so far. Meanwhile you can fix this by turning this off:

Thanks for the patience with this!

[schlomo]

That indeed helped, thanks a lot!

[waydabber]

No idea what was wrong, but I now added an extra protection that the longPress activity can start only when the leftMouseDown is also happening during the valueChanged event, this should help avoid any unwanted triggering of the slider favorite setting behavior.

When possible, I'll add an updated build with this, will post the link here as well for testing.

Thank you!

[waydabber]

Note - here is an interim build with this and some other bug fixes:

https://github.com/waydabber/BetterDisplay/releases/download/v2.0.0-pre-release/BetterDisplay-v2.3.4-b29903-pre.zip

[waydabber]

I'd appreciate if you could test this @schlomo and confirm if the issue is fixed (as I was not able to reproduce it, so fixed it kinda blindly by guessing what might be a problem based on the code).

[schlomo]

Hi @waydabber thanks a lot! I installed the pre-build and couldn't observe the problem any more.

[waydabber]

Thanks for the feedback @schlomo! :)