Todo: Improve bit depth over the codebase

Open Shinyzenith opened this issue 2 years ago • 5 comments

Some parts of our codebase have hardcoded 8 bit for PNG outputs, we should ideally choose 16 bit as that is the maximum supported depth for PNG encoding.

Feb 12 '24 10:02 Shinyzenith

Can I be assigned to this issue? cc @Shinyzenith (we had a conservation on discord about this)

Feb 28 '24 08:02 0xnullifier

Hi Utkarsh, I believe @nukelet over on the discord had asked to work on this. If you can get a patch ready then I'd suggest to go for it.

Feb 28 '24 08:02 Shinyzenith

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

Feb 28 '24 08:02 0xnullifier

Hi! Yes, I'm working on this right now and planning to send a patch very soon. :slightly_smiling_face:

Feb 28 '24 14:02 nukelet

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

#87 is up for grabs but fair warning, the freeze pr set introduced a lot of significant API and cli changes so pick your poison wisely.

Feb 28 '24 15:02 Shinyzenith