wayshot icon indicating copy to clipboard operation
wayshot copied to clipboard

Fix for 'cargo test'

Open id3v1669 opened this issue 1 year ago • 9 comments

pr to fix issue #113

id3v1669 avatar Apr 06 '24 10:04 id3v1669

to freeze-feat-andreas branch, that is the developing branch

Decodetalkers avatar Apr 06 '24 10:04 Decodetalkers

can you rebase it? thanks

Decodetalkers avatar Apr 06 '24 11:04 Decodetalkers

can you rebase it? thanks

I'm working on a new commit as in branch freeze-feat-andreas a lot more errors during cargo test. I'll ping you when done.

id3v1669 avatar Apr 06 '24 11:04 id3v1669

@Decodetalkers Done. Added also ignore to pixel-art in region.rs as it was also handled as error by cargo test Bumped flake.lock due to error:

error: package clap_derive v4.5.3 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0

id3v1669 avatar Apr 06 '24 12:04 id3v1669

@Decodetalkers Done. Added also ignore to pixel-art in region.rs as it was also handled as error by cargo test Bumped flake.lock due to error:

error: package clap_derive v4.5.3 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0

maybe you can update nix, to which has higher version of rust

Decodetalkers avatar Apr 06 '24 12:04 Decodetalkers

maybe you can update nix, to which has higher version of rust

That's why I bumped flake.lock file, so newer version of cargo is used now cargo 1.76.0.

id3v1669 avatar Apr 06 '24 12:04 id3v1669

I think this is a good time to run cargo test during builds even though tests don't exist. This helps us avoid such issues further down the line and we do have a WIP pr for integration testing in the future. How do you feel about this change? @id3v1669

Shinyzenith avatar Apr 06 '24 19:04 Shinyzenith

I think this is a good time to run cargo test during builds even though tests don't exist. This helps us avoid such issues further down the line and we do have a WIP pr for integration testing in the future. How do you feel about this change? @id3v1669

Sounds great, should I add cargo test into Makefile in this pr or you will do that later in pr for integration testing?

id3v1669 avatar Apr 06 '24 19:04 id3v1669

Feel free to add it to this pr itself. Since it's a fairly minor change.

Shinyzenith avatar Apr 06 '24 19:04 Shinyzenith