swhkd
swhkd copied to clipboard
[fix] remove rfkill switch support
Fix #174
The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.
CC: @zubairmh Thoughts?
CC: @zubairmh Thoughts?
Maybe it's better to make it optional to keep support for distros that need it?
CC: @zubairmh Thoughts?
Maybe it's better to make it optional to keep support for distros that need it?
Most distro's seem to be unaffected, if someone is able to confirm that their distro is affected then it might be considerable.
It also seems inconsistent to have rfkill switch support for one distro and not for others
Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.
Does that sound acceptable? CC: @id3v1669
Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.
Does that sound acceptable? CC: @id3v1669
Just tested on 5 distros:
Distro | wifi dies with rfkill | wifi dies without rfkill |
---|---|---|
Opensuse(Tumbleweed) | + | + |
NixOS(unstable) | - | + |
NixOS(unstable) | * | - |
Debian 12 | - | + |
Alpine | * | - |
*
doesn't work with rfkill at all
If your tests show that other distros are not affected by removing rfkill, it's ok to merge. In rare cases, the patch can be applied during packaging.
Hey, @id3v1669
I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL
from the list of switches?
Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing
SW_RFKILL_ALL
from the list of switches?
Yes, second column mean that wifi dies even after removing SW_RFKILL_ALL
.
No idea why that is happening, but on different devices I've got different behavior with same configuration.
This table works for Thinkpad L14 Gen 3 with intel AX210/AX1675 wifi module.
On Intel Nuc 11 PH with intel AX201 behavior is different and results are not in table.