swhkd icon indicating copy to clipboard operation
swhkd copied to clipboard

[fix] remove rfkill switch support

Open aadilshabier opened this issue 11 months ago • 7 comments

Fix #174

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.

aadilshabier avatar Mar 10 '24 18:03 aadilshabier

CC: @zubairmh Thoughts?

Shinyzenith avatar Mar 23 '24 17:03 Shinyzenith

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

id3v1669 avatar Apr 03 '24 11:04 id3v1669

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

Most distro's seem to be unaffected, if someone is able to confirm that their distro is affected then it might be considerable.

It also seems inconsistent to have rfkill switch support for one distro and not for others

zubairmh avatar Apr 03 '24 14:04 zubairmh

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

Shinyzenith avatar Apr 06 '24 19:04 Shinyzenith

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

Just tested on 5 distros:

Distro wifi dies with rfkill wifi dies without rfkill
Opensuse(Tumbleweed) + +
NixOS(unstable) - +
NixOS(unstable) * -
Debian 12 - +
Alpine * -

* doesn't work with rfkill at all

If your tests show that other distros are not affected by removing rfkill, it's ok to merge. In rare cases, the patch can be applied during packaging.

id3v1669 avatar Apr 07 '24 04:04 id3v1669

Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

aadilshabier avatar Apr 15 '24 15:04 aadilshabier

Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

Yes, second column mean that wifi dies even after removing SW_RFKILL_ALL . No idea why that is happening, but on different devices I've got different behavior with same configuration. This table works for Thinkpad L14 Gen 3 with intel AX210/AX1675 wifi module. On Intel Nuc 11 PH with intel AX201 behavior is different and results are not in table.

id3v1669 avatar Apr 16 '24 07:04 id3v1669