node-compress icon indicating copy to clipboard operation
node-compress copied to clipboard

Fix node-compress compiling

Open elliotttf opened this issue 13 years ago • 7 comments

I've updated the compress.cc code to handle the removal of node_events.h. I'm not 100% sure Iv'e done this correctly, but the test scripts seem to work.

FWIW, I found this post helpful: [http://permalink.gmane.org/gmane.comp.lang.javascript.nodejs/28298]

elliotttf avatar Nov 11 '11 18:11 elliotttf

+1

niftylettuce avatar Nov 20 '11 05:11 niftylettuce

Also I noticed that after locally running node-waf configure && node-waf build that the sym link path is changed to build/Release/compress versus build/default/compress.

Can you duplicate this and do we need to fix? Ty.

niftylettuce avatar Nov 20 '11 06:11 niftylettuce

Yeah, it should be build/default/compress otherwise I am getting "Cannot find module 'compress'" error.

madhums avatar Nov 20 '11 11:11 madhums

Will this pull request be merged or no? compress won't run with node 0.6 :(

panosru avatar Jan 26 '12 02:01 panosru

Is there anyway to use your fork @elliotttf to install a package that is dependent on compress?

ghost avatar May 10 '12 14:05 ghost

Yes @ecoffey-trada . You can use it like this

Put this in your package.json

"compress": "git+ssh://git://github.com/elliotttf/node-compress.git"

madhums avatar May 10 '12 14:05 madhums

Thanks @madhums :-)

ghost avatar May 10 '12 14:05 ghost