waveterm
waveterm copied to clipboard
wavetermdev
Hope to add feature: set default shell
Is your feature request related to a problem? Please describe. When my system's shell is bash, but I want to use fish as my terminal shell, I find that currently I can't do that.
Describe the solution you'd like I want to add a setting that allows users to set the default shell for the terminal.
Thanks for submitting. We don't currently support fish. Right now the product only supports bash. We are planning on adding zsh support, but we likely won't support fish in the near term. The reason is that we're trying to build a lot of the usability features in fish right into Wave directly.
I also wanted to change the shell to fish, which is set as my default, as soon as I found out that the shell doesn't behave normally. I was surprised to see that the terminal doesn't respect the system defaults, and furthermore that it's not shell-agnostic.
it should respect the default system shell. i use fish, so this is a deal breaker for me.
Agree with the sentiment, please consider making the product shell-agnostic.
This would even engage windows users who are stuck in WSL trying to deploy Wave or powershell perhaps.
Sadly warp doesn't care about fish users either.. oh well, back to the default terminal then I guess.
Since this is legacy now and all shells are supported. It should be pretty easy to let the user choose, which shell is used by default for a terminal block, in the config.
Yes. You can find the exact setting on the configuration-page on the website. You will have to edit the config-file and set the default shell path for new terminal blocks to fishs path.
Thanks that does give me fish but none of my opening config files seem to run.
@jubishop does fish load different settings files depending on whether it was launched as a "login shell" or not? I wonder if waveterm does or does not launch shells in this mode?
Yes it does but even basic etc/profile isn’t running which should be fired further up stack from anything fish is doing
cheers,
- Justin Bishop http://jubishop.com/
On October 18, 2024, GitHub Notifications @.***> wrote:
@jubishop https://github.com/jubishop does fish load different settings files depending on whether it was launched as a "login shell" or not? I wonder if waveterm does or does not launch shells in this mode?
— Reply to this email directly, view it on GitHub https://github.com/wavetermdev/waveterm/issues/91#issuecomment-2423376247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADG3KBG52QJJD434Y5O3LZ4GMEDAVCNFSM6AAAAAA723PH7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGM3TMMRUG4 . You are receiving this because you were mentioned.Message ID: @.***>