waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard

Add bash history as ctrl-R option

Open mroeling opened this issue 2 years ago • 2 comments

When searching in history, there are multiple options to find the command you're looking for, for screen and remote. But I'm missing the option to search in the "normal" bash history. Since there already are 3 options for ctrl-S, perhaps an option to add this as (default?) option to ctrl-R?

#bash> history

While trying: history does not give any results. Then I tried bash and history from there, and the result was showing the history, but unexpectedly, the shell was opened within the command result screen. That might be an undesired result? image image

mroeling avatar Nov 24 '23 09:11 mroeling

Thanks for submitting! Completely integrating bash history could be tricky. Your suggestion about having bash history show up as a separate option in ctrl-r is really good though -- that definitely feels doable. Also you're right about the normal "history" command not working. Will think about how to get a workaround for that (or just get it working) so you can still do easy legacy history searches like "history | grep foo".

sawka avatar Nov 24 '23 20:11 sawka

You cannot search native zsh/bash history in Wave terminal???

My "history" cmd output is also empty (tried on both Mac zsh and a remote Rocky 9), while any other terminal emulator does return data.

Warp terminal's fancy history search worked even on the remote (it searches bash history).

levesduzw avatar Jul 20 '24 17:07 levesduzw