waveterm Crash when cell input is >3989 characters

0.7.2 on macOS crashes for me for when the pasted input is 3989 characters or longer.

Tested with:

defrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjgdjushcfbvdefrdvtgdrsefrvgbvbvdefrdvtgdrsefrvgbvjdbjfvgdhbcfvjrvgbvjdbjfff

The resulting behavior is quite user unfriendly. "Wave Client Disconnected" popup flashes on screen, then it seems the terminal backend is restarted, that crashes again, and repeat. The screen flashes like this forever.

Apr 11 '24 14:04 reform-chipper

thanks for reporting! was able to reproduce the bug, really bad, definitely a priority to fix.

Apr 23 '24 18:04 sawka

Just merged a PR to address this issue - https://github.com/wavetermdev/waveterm/pull/606

Apr 25 '24 22:04 sawka

The PR says limit input size to 10k characters, but it's actually 4k:

[error] command length too long len:10240, max:4096

Also, I don't think this resolves the issue, at least not for me. It's common for me to copy a large HTTP request as CURL and paste it in to the terminal. I now have to resort to a different terminal to execute it.

Jun 18 '24 13:06 reform-chipper