Fix WebSocket utilities and Add OSC 52 clipboard support
-
Fix WebSocket utilities timing issue:
- Replace async import() with synchronous require() for Node.js 'ws' module
- Prevents race condition where newWebSocket was called before import resolved
- Fixes fallback to browser WebSocket in Node.js environment
-
Add handleOsc52Command() for set/query/clear clipboard operations
-
Register OSC 52 handler in TermWrap constructor
-
Support base64 encoding/decoding for clipboard data
-
Add error handling for clipboard access failures
Walkthrough
The changes introduce a new function, handleOsc52Command, in the terminal wrapper module to handle OSC 52 terminal escape sequences for clipboard operations. The function processes clipboard clear, query, and set actions, integrating with the system clipboard and encoding/decoding data as needed. The TermWrap class constructor is updated to register this handler with the terminal parser. Separately, in the WebSocket utility module, the asynchronous dynamic import of the "ws" module for Node.js is replaced with a synchronous require call within a try-catch block to address timing issues. No exported interfaces are changed in the WebSocket utility.
Estimated code review effort
๐ฏ 3 (Moderate) | โฑ๏ธ ~15 minutes
[!NOTE]
๐ MCP (Model Context Protocol) integration is now available in Early Access!
Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.
๐ Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
๐ฅ Commits
Reviewing files that changed from the base of the PR and between 392488b5fdf9aaa3bc254088ecc58bffb281b77f and d769694ba41a7b0165cc6065c242145b1ca2fb50.
๐ Files selected for processing (2)
frontend/app/view/term/termwrap.ts(2 hunks)frontend/util/wsutil.ts(1 hunks)
๐ง Files skipped from review as they are similar to previous changes (2)
- frontend/util/wsutil.ts
- frontend/app/view/term/termwrap.ts
โจ Finishing Touches
- [ ] ๐ Generate Docstrings
๐งช Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
๐ชง Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai generate unit teststo generate unit tests for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.