fix: resolve OpenAI backend compatibility issues and build failures
Summary
This PR resolves multiple critical issues preventing proper OpenAI integration in WaveTerm, including build failures on Intel macOS and API compatibility problems.
Issues Fixed
🔧 Build Failures
- Problem: Duplicate symbol linker errors (
dlopenconflicts) when building wavesrv on Intel macOS - Solution: Update
github.com/ebitengine/puregodependency from v0.8.2 to v0.8.4 - Impact: Enables successful compilation across all supported architectures
🚫 API Compatibility
- Problem: "400 Bad Request: user and assistant roles should be alternating" errors
- Root Cause: WaveTerm was sending "error" role messages to OpenAI API
- Solution: Filter out "error" role messages in
convertPrompt()function - Impact: Clean message flow without API rejections
🤖 Enhanced Model Support
- Problem: Newer model families (gpt-4.1+, o4+, o3+) not properly handled
- Solution: Extend reasoning model detection and use
max_completion_tokensparameter - Impact: Full support for latest OpenAI model releases
Technical Changes
Files Modified
go.mod/go.sum: Dependency version bumppkg/waveai/openaibackend.go: Core compatibility fixes
Code Changes
// Filter out invalid role types
if p.Role == "error" {
continue
}
// Extended model family detection
if strings.HasPrefix(request.Opts.Model, "o1-") ||
strings.HasPrefix(request.Opts.Model, "gpt-4.1") ||
strings.HasPrefix(request.Opts.Model, "o4-") ||
strings.HasPrefix(request.Opts.Model, "o3-") {
req.MaxCompletionTokens = request.Opts.MaxTokens
req.Stream = false
Test Plan
- [x] Build wavesrv successfully on Intel macOS (darwin/x64)
- [x] Verify OpenAI API calls complete without 400/401 errors
- [x] Test multiple model configurations (gpt-4o, gpt-4o-mini)
- [x] Confirm backward compatibility with existing setups
- [x] Validate error message filtering prevents API rejections
Compatibility
- ✅ Backward Compatible: Existing configurations continue to work
- ✅ Cross-Platform: Fixes compilation issues across architectures
- ✅ API Stable: No breaking changes to WaveTerm's AI interface
Related Issues
Addresses build failures and API integration problems reported in development environments using OpenAI backend.
🤖 Generated with Claude Code
Walkthrough
The changes update the github.com/ebitengine/purego dependency in the go.mod file from version v0.8.2 to v0.8.4. In the pkg/waveai/openaibackend.go file, the convertPrompt function is modified to skip prompt messages with the role "error" when preparing OpenAI chat completion requests. The StreamCompletion method is also updated to include models with prefixes "gpt-4.1", "o4-", and "o3-" alongside "o1-" for which the non-streaming API is used, disabling streaming and setting MaxCompletionTokens accordingly. There are no changes to the declarations of exported or public entities.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9a44c9c10ed9a8edaadc77c578d22bc3dfd3945a and bb77b90cc330a9f760a5db962b31f954dcc21e69.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
go.mod(1 hunks)pkg/waveai/openaibackend.go(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/waveai/openaibackend.go
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
(addressed in other fixes, we also have a new AI system)