waveterm
waveterm copied to clipboard
[Bug]: Filemanager crashes when filtering on non-existent character
Current Behavior
In the file manager, typeing characters is used as a way to filter the list of files. This works fine until you type a letter that diesn't exist in any filename. A crash occurs:
Error:
Error
at Object.getRow (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:80825:17)
at file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:80190:31
at Array.map (<anonymous>)
at table2._getPinnedRows (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:80189:52)
at file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:80201:136
at Object.getTopRows (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:78420:14)
at TableBody (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:82650:14)
at Nh (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:14089:10)
at cj (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:14743:10)
at Vk (file:///Applications/Wave.app/Contents/Resources/app.asar/dist/frontend/assets/index-BU5Cfxta.js:17069:101)
The only way out is to close the block and re-open it.
Expected Behavior
I would expect the list shown to be empty and/or a message to be shown.
Steps To Reproduce
wave 0.11.2 (202503082050) on Sequoia15.3.2 (24D81)
- Open a Wave terminal
- Open a File Manager block
- Type a character which doesn't exist in any filenames
Wave Version
0.11.2 (202503082050)
Platform
macOS
OS Version/Distribution
15.3.2 (24D81)
Architecture
x64
Anything else?
No response
Questionnaire
- [ ] I'm interested in fixing this myself but don't know where to start
- [ ] I would like to fix and I have a solution
- [ ] I don't have time to fix this right now, but maybe later
I confirm this bug
+72 (the amount of times i run into this bug in a day).