[Bug]: Graph prevents the installation of `wsh`
Current Behavior
Hi
I'm using the Windows version of the waveterm: Client Version 0.11.2 (202503082057) Update Channel: latest
The issue I ran in is as following:
When there is a sysgraph running, then the wsh is failing to be installed.
It doesn't matter, if it is a local sysgraph, or a sysgraph connected to any other ssh host.
The open graph must not be in the same workspace. I was also able to re-create the issue, when I have left open a graph in another workspace and then gone back to my original workspace and started there the ssh connection. It still failed to install wsh.
The reason why it fails seems to be, that the shell isn't recognized correctly.
[conndebug] remoteName: "root@PiHole", connType: ssh, wshEnabled: false, shell: "", shellType:
When I close all graphs in all workspaces and tabs, then the command succeeds without any issues.
I have here the full log of the connection, when it happens to fail:
[conndebug] stopping blockcontroller due to conn change "local" => "root@PiHole"
[conndebug] trying to connect to "root@PiHole"...
[conndebug] connectInternal root@PiHole
[conndebug] ConnectToClient root@PiHole (jump:0)...
[conndebug] ssh dial 192.168.1.3:22
[conndebug] trying keyfile "~/.ssh/id_ed25519_Proxmox_LXC_Pi_Hole"...
[conndebug] successful ssh connection to 192.168.1.3:22
[conndebug] normalized knownhosts address: [email protected]
[conndebug] running tryEnableWsh...
[conndebug] wsh settings enable:false ask:false
[conndebug] wsh not enabled: conn:wshenabled set to false
[conndebug] successfully connected (wsh:false)
[conndebug] start blockcontroller 6dc26a6d-1f45-428b-96f7-3980bfb73462 "shell" ("root@PiHole") (curstatus init) (force false)
[conndebug] BlockController.run() "6dc26a6d-1f45-428b-96f7-3980bfb73462"
[conndebug] DoRunShellCommand
[conndebug] resetTerminalState: resetting terminal state
[conndebug] remoteName: "root@PiHole", connType: ssh, wshEnabled: false, shell: "", shellType:
[conndebug] created swaptoken: 5fff6412-a3d2-4375-9f37-cbc177b4f398
Linux pihole 6.8.12-5-pve #1 SMP PREEMPT_DYNAMIC PMX 6.8.12-5 (2024-12-03T10:26Z) x86_64
The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.
Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
Last login: Sun Mar 9 16:18:34 2025 from 192.168.1.100
Here is my entry from my ssh config file in %userprofile%\.ssh\config which I have used for this connection.
Host PiHole
User root
HostName 192.168.1.3
ForwardAgent yes
IdentitiesOnly yes
AddKeysToAgent yes
IdentityFile ~/.ssh/id_ed25519_Proxmox_LXC_Pi_Hole
To get wsh installed, there seems only be one solution at the moment.
- Close all graphs in all tabs and all workspaces
- Check the
connections.jsonfile, if there have been created a entry"conn:wshenabled": falsefor the particular connection which has failed and clear the whole block, or set the parameter to true. - restart Wave
- Connect again to the previously failed host. It should work now.
Expected Behavior
The installation of wsh shouldn't fail when there are open sysgraphs.
Steps To Reproduce
Windows version of the waveterm Client Version 0.11.2 (202503082057) Update Channel: latest
- Start Wave
- Open a graph
- connect with ssh to the host and accep the installation of
wsh
Settings used in %userprofile%\.ssh\config for this connection:
Host PiHole
User root
HostName 192.168.1.3
ForwardAgent yes
IdentitiesOnly yes
AddKeysToAgent yes
IdentityFile ~/.ssh/id_ed25519_Proxmox_LXC_Pi_Hole
Wave Version
v0.11.2 (202503082057)
Platform
Windows
OS Version/Distribution
Windows 11 Pro
Architecture
x64
Anything else?
Here's some information of the host, where I connect to (The host, where installation of wsh fails):
sh -c "uname -sm"
Linux x86_64
cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description: Debian GNU/Linux 12 (bookworm)
Release: 12
Codename: bookworm
echo $SHELL
/bin/zsh
zsh --version
zsh 5.9 (x86_64-debian-linux-gnu)
Questionnaire
- [ ] I'm interested in fixing this myself but don't know where to start
- [ ] I would like to fix and I have a solution
- [ ] I don't have time to fix this right now, but maybe later