waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard

[Bug]: SSH Connection Fails When Host Alias Contains Underscore

Open duracell opened this issue 10 months ago • 0 comments

Current Behavior

When selecting an SSH connection where the Host alias contains an underscore (e.g., test_1): 1. No connection attempt is made (no outgoing TCP packets detected). 2. Clicking “Reconnect” has no effect. 3. Renaming the Host alias to remove the underscore (e.g., test1) resolves the issue. It works fine outside of Wave.

Screenshot of not working: Image

Screenshot of working: (ignore the error, this is just for demonstration of a working connection). Image

Expected Behavior

  1. Connections with underscores in Host aliases should work if supported by SSH.
  2. If unsupported, a clear error message should appear (e.g., “Invalid characters in SSH Host alias”).

Steps To Reproduce

  1. Create SSH config entry:
Host test_1  # Underscore in Host alias
  HostName example.com
  User test
  1. Attempt connection via Wave’s laptop icon.

Wave Version

v0.11.0

Platform

macOS

OS Version/Distribution

MacOS 15.3.1

Architecture

arm64

Anything else?

No response

Questionnaire

  • [ ] I'm interested in fixing this myself but don't know where to start
  • [ ] I would like to fix and I have a solution
  • [ ] I don't have time to fix this right now, but maybe later

duracell avatar Feb 23 '25 11:02 duracell