waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard
verified publisher icon wavetermdev

[Bug]: waveterm injecting NODE_ENV into my terminal which cause incorrect behavior in nodejs package managers

Open Satont opened this issue 11 months ago • 5 comments

Current Behavior

Waveterm injecting NODE_ENV, which cause my pnpm install only production deps in my own projects.

Expected Behavior

Shuldn't be injected

Steps To Reproduce

echo $NODE_ENV

Wave Version

v0.10.4

Platform

Linux

OS Version/Distribution

Archc

Architecture

x64

Anything else?

No response

Questionnaire

  • [x] I'm interested in fixing this myself but don't know where to start
  • [ ] I would like to fix and I have a solution
  • [ ] I don't have time to fix this right now, but maybe later

Satont avatar Jan 25 '25 03:01 Satont

This should be very easy to fix. In runWaveSrv in emain-wavesrv.ts, delete NODE_ENV from envCopy before the wavesrv process is started.

esimkowitz avatar Jan 25 '25 08:01 esimkowitz

Hmm I'm not seeing NODE_ENV getting set, what value is it getting set to and what value is it set to in other terminals?

esimkowitz avatar Jan 27 '25 19:01 esimkowitz

@esimkowitz

what value is it getting set

production

what value is it set to in other terminals

It does not exists in other terminals.

Satont avatar Jan 29 '25 07:01 Satont

What mechanism did you use to install Wave?

esimkowitz avatar Jan 29 '25 09:01 esimkowitz

What mechanism did you use to install Wave?

https://aur.archlinux.org/packages/waveterm-bin through yay

Satont avatar Jan 29 '25 10:01 Satont