waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard
verified publisher icon wavetermdev

Date filter slection in history is not working as expected from the label

Open YJDoc2 opened this issue 2 years ago • 2 comments

Describe the bug The history filtering is not working as expected. Say I ran several commands yesterday, then ran clear, closed Wave, shut down machine. I opened Wave today again, and ran some more commands (in same workspace, in same tab). Now when I go the history section, there is a filter named 'From'. I expect that I get list of all commands that I ran from the selected date. However it seems that the commands I get are upto the selected date.

To Reproduce

  1. create a workspace + tab (or use existing)
  2. run some commands, run clear (not sure if clearing plays a part or not, but I did run it), close wave and do something else for rest of the day
  3. the next day run some more commands in the same workspace+tab.
  4. go to history section, and select current day in the calendar selection.
  5. similarly select the previous day in calendar selection, and several days back in the selection

Expected behavior

  • When selected current date, I expect to get commands run only today ; however I also see commands I ran ysterday
  • When selected yesterday's date, I see only the command I ran yesterday, but I expect to see those and today's commands
  • When selected a date before I installed Wave, I see 'No history Item found' ; I expect to see all commands I ran till now

Desktop (please complete the following information):

  • OS: Linux x64 Pop OS
  • Version v0.5.1 20231206-015352

Additional context It seems that the 'From' in date selection is actually used as 'Upto' internally? It ok if that is the intention, but the label seems to create confusion.

YJDoc2 avatar Dec 19 '23 07:12 YJDoc2

Thanks for submitting. I understand your point about the label. The history search UI needs to be improved and at that point we'll probably add a real date range picker. My thought when building that control was that since the commands are sorted in reverse time order, the only date filter that makes sense would be to start searching "from" a date in the past.

sawka avatar Dec 19 '23 07:12 sawka

Hey, cool, thanks! It took me a bit before I wrapped my head around the way the filter is working, so maybe label / behavior change should be considered whenever the UI is revisited. Should I close this issue, or keep it open?

YJDoc2 avatar Dec 21 '23 09:12 YJDoc2