waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard

[Bug]: No blocks and no wsh installed

Open javawithrocky opened this issue 1 year ago • 16 comments

Current Behavior

In watching intro videos online it seems like Wave has Warp like feature of each command and it's output is a block. That doesn't seem to be the case. Also, wsh is not available in Wave as well.

image

Expected Behavior

  1. wsh should be installed?
  2. I should be able to see and copy blocks like in Warp?

Steps To Reproduce

  1. Download Wave (v0.10.4)
  2. You won't see blocks
  3. wsh is not installed.

NOTE: I have 2019 Mac

Wave Version

v0.10.4

Platform

macOS

OS Version/Distribution

Sequoia 15.1.1

Architecture

x64

Anything else?

image

Questionnaire

  • [ ] I'm interested in fixing this myself but don't know where to start
  • [ ] I would like to fix and I have a solution
  • [ ] I don't have time to fix this right now, but maybe later

javawithrocky avatar Dec 25 '24 17:12 javawithrocky

Could you send your log file to [email protected]? You can find your logfile location by running wsh wavepath log from within Wave

esimkowitz avatar Dec 26 '24 15:12 esimkowitz

Sure. Please find it attached.

waveapp.log

javawithrocky avatar Dec 26 '24 17:12 javawithrocky

What shell are you using?

esimkowitz avatar Dec 26 '24 18:12 esimkowitz

Fish shell. Sorry, I should have mentioned this earlier.

javawithrocky avatar Dec 26 '24 22:12 javawithrocky

having the same issue here on mac. also wsh cannot be installed on remote linux server i connect

Disconnected from "[email protected]@1.1.1.1" unable to use wsh: timeout waiting for connserver to register i get this message when i connect on a remote linux server

andsty avatar Dec 27 '24 12:12 andsty

Partly the same issue on Ubuntu 24.04 - while wsh gets installed, locally as well as remote, there are no blocks present anywhere.

ghost avatar Dec 27 '24 21:12 ghost

@javawithrocky thanks for your patience. been going through all the fish startup code, but I can't find the inconsistency (yet).

two things that would really help me figure this out is:

(1) if you could let me know what your $PATH is set to. echo $PATH (i'm curious if our wsh bin dir got added properly to your path).

(2) if you could do an ls -l "/Users/rhasija/Library/Application Support/waveterm/bin" (you'll need the quotes cause of the space in Application Support). i'd expect to see wsh in there. here's my output:

total 14280
-rwxr-xr-x@ 1 mike  staff  7308274 Dec 27 17:55 wsh

sawka avatar Dec 28 '24 02:12 sawka

Sure thing:

~/L/A/waveterm [127] $ ls -l "/Users/rhasija/Library/Application Support/waveterm/bin"                                                                                                                     16:19:06
total 14784
-rwxr-xr-x@ 1 rhasija  staff  7567408 Dec 26 10:50 wsh*
~/L/A/waveterm $ echo $PATH                                                                                                                                                                                16:19:15
/Users/rhasija/.asdf/shims /usr/local/opt/asdf/libexec/bin /usr/local/opt/mysql-client/bin /usr/local/opt/m4/bin /Users/rhasija/.local/bin /Users/rhasija/.fig/bin /Users/rhasija/.cargo/bin /Users/rhasija/.nvm/versions/node/v12.22.1/bin /Users/rhasija/.local/share/fig/plugins/git-flow /usr/ucb /Users/rhasija/.sdkman/candidates/java/current/bin /Users/rhasija/.sdkman/candidates/kotlin/current/bin /Users/rhasija/.sdkman/candidates/maven/current/bin /Users/rhasija/.sdkman/candidates/gradle/current/bin /Users/rhasija/.sdkman/candidates/quarkus/current/bin /usr/local/go/bin /Users/rhasija/.fig/bin /Users/rhasija/.cargo/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin
~/L/A/waveterm $                                                                                                                                                                                           16:19:23

Once I added the path like below to ~/.config/fish/config.fish then wsh is found and it works:

set -gx PATH /Users/rhasija/Library/Application\ Support/waveterm/bin $PATH

So, it seems like the issue is as simple as PATH not being updated.

javawithrocky avatar Dec 28 '24 23:12 javawithrocky

Hello, any updates on this? I am a bit worried that the issue will auto close if no activity occurs within a time frame.

Also any word in each command being a block? Is that no longer the case with Wave? Just want to understand what to expect.

javawithrocky avatar Jan 01 '25 04:01 javawithrocky

Hi, we don't auto-close issues so no worries there, we're working on some general bug bashing in the shell detection code that may fix this, however due to the holidays, we're not going to be publishing a beta until probably next week.

We understand that there's mixed messaging here because of the existing coverage of our legacy app, but we do not currently support rendering each command as a separate block. This was a conscious decision to improve compatibility with more shell configurations as the old way we were doing this was breaking too many things for too many people and the feedback we were getting was that it wasn't helpful enough. We're looking into ways we can bring this back as an alternative display method, but I cannot give you a timeline for when it would return. If you have more questions about this, feel free to reach out to us on Discord or open a new Discussions thread, happy to discuss further there.

esimkowitz avatar Jan 01 '25 18:01 esimkowitz

Hi,

I noticed the following text on the main GitHub page:

Command Blocks for isolating and monitoring individual commands with auto-close options

If "Command Blocks" is not a feature, even if temporarily, I recommend removing the reference. It could be confusing for new users and, at worst, might be perceived as misleading.

javawithrocky avatar Jan 06 '25 04:01 javawithrocky

we're repurposing this term in the new app to refer to single-command widgets, which is a new feature in 0.10. It is not the same thing as the block-style command history from the old app

esimkowitz avatar Jan 06 '25 21:01 esimkowitz

If you're trying to use blocks differently, then I highly recommend renaming them. "Command block" has already been coined as something that Wave no longer offers. I watched your YouTube demo, got super excited to switch off warp, then spent an hour trying to figure out why I didn't have actual command blocks and why the layout wasn't anywhere near what had been demoed and eventually found this legacy issue thread. You're saying in that quote from your README that the blocks are for individual commands—they are not. Wave is a cool project, but you're advertising it as something it isn't anymore and it's very confusing and frustrating.

sloraris avatar Feb 24 '25 22:02 sloraris

@sloraris +1

started https://github.com/wavetermdev/waveterm/discussions/2061

LilWatson avatar Mar 14 '25 22:03 LilWatson

Absolutely agree on the naming thing. They aren't "blocks" they're panes.

Re-defining a term used for decades to pretend a key feature wasn't removed is a bait and switch. It caused me to waste far too much time thinking something was broken. If this were a paid product I'd be reporting it for false advertising while requesting a charge-back.

I'm back to considering other alternatives while using tmux for all the missing pane management functionality.

EmperorArthur avatar May 31 '25 06:05 EmperorArthur

I will add to the being extremely confused by this camp. If it's not a feature then that's fine, but please remove it from your README in that case. By far the most viewed YouTube videos featuring this terminal show the old design. That, combined with all the documentation talking about command blocks and the README makes it very easy to spend far too long trying to enable something that doesn't exist.

Kas-tle avatar Nov 13 '25 20:11 Kas-tle