Deleting current workspace switches to another if it can instead of closing

[Jalileh]

        if (workspaceList.length > 1 && ww?.workspaceId == workspaceId){
            
            const workspaceIdindex : any =  workspaceList.findIndex(wse => wse.workspaceid === workspaceId);
                
            const moveIndex = (workspaceIdindex > 1) ? workspaceIdindex - 1 : workspaceIdindex + 1;   
            const PrevNextWorkspace : any = workspaceList[moveIndex]
            
            await ww.switchWorkspace(PrevNextWorkspace.workspaceid);
            relaunchBrowserWindows(); // the blank window bug from 0.10.1 OCCASIONALLY occurs if this is not here,  ( issue #1567 )
        }
        
        await WorkspaceService.DeleteWorkspace(workspaceId);

[CLAassistant]

All committers have signed the CLA.

[coderabbitai[bot]]

[!CAUTION]

Review failed

The head commit changed during the review from 2cc22412c6a2286366f43800dc182f0a68927e4d to c1cf5396bfc2fb34bcdfbdba7e74e064c2e5cc4c.

Walkthrough

The changes in the emain-window.ts file enhance the logic for deleting workspaces within the application. The delete-workspace IPC handler has been modified to include a new conditional structure that checks if the workspace being deleted is the active one and if multiple workspaces are available. If both conditions are satisfied, the handler identifies the next workspace to switch to and invokes ww.switchWorkspace() before deleting the specified workspace, ensuring an active workspace remains.

The deletion logic has been refined: if the workspace to be deleted is the only one left, it is deleted along with its associated window. If multiple workspaces are present, the application first switches to a different workspace before proceeding with the deletion. The control flow has been adjusted to manage the workspace deletion process more effectively, particularly when the active workspace is involved. No changes were made to the declarations of exported or public entities in this update.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[esimkowitz]

Thank you for this submission! Please take a look at the CLA and sign it when you can. We cannot accept your submission without this. Let me know if you have any questions.