waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard

[Bug]: term:localshellopts does not work for Powershell

Open neradp opened this issue 1 year ago • 2 comments

Current Behavior

When I set "term:localshellopts": "-nologo" for "term:localshellpath": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" it does nothing. Powershell runs as normal.

Expected Behavior

Powershell without "logo".

Steps To Reproduce

When I set "term:localshellopts": "-nologo" for "term:localshellpath": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" it does nothing. Powershell runs as normal.

Wave Version

0.10.1

Platform

Windows

OS Version/Distribution

Windows 11 24H2

Architecture

x64

Anything else?

No response

Questionnaire

  • [ ] I'm interested in fixing this myself but don't know where to start
  • [ ] I would like to fix and I have a solution
  • [ ] I don't have time to fix this right now, but maybe later

neradp avatar Dec 15 '24 08:12 neradp

Just checking, are you running on arm or was that a typo?

esimkowitz avatar Dec 15 '24 09:12 esimkowitz

sorry it was a typo... amd64 👯

neradp avatar Dec 15 '24 20:12 neradp

The correct config format for this is:

{
  ...
  "term:localshellopts": ["-NoLogo"]
}

I am going to close this as not planned, since this is by design, but I'll add a note to the docs

esimkowitz avatar Dec 17 '24 00:12 esimkowitz