waveterm icon indicating copy to clipboard operation
waveterm copied to clipboard

[Bug]: Can't right click terminal tab to change themes

Open Printoiid opened this issue 1 year ago • 15 comments

Current Behavior

When launching a new session on a fresh install, it's sometimes impossible to right click on a tab to access the context menu for that tab

image

Expected Behavior

Right click on a tab within the application allows context menu to appear to display options for that tab

image

Steps To Reproduce

  1. Install Wave terminal
  2. Open Wave terminal
  3. Right click tab to open context menu

Wave Version

0.9.3

Platform

Windows

OS Version/Distribution

Win 10

Architecture

x64

Anything else?

Control + Shift + R to force a refresh yields no results.

Questionnaire

  • [ ] I'm interested in fixing this myself but don't know where to start
  • [ ] I would like to fix and I have a solution
  • [ ] I don't have time to fix this right now, but maybe later

Printoiid avatar Dec 05 '24 01:12 Printoiid

We don't have a native ARM build for Windows at the moment. I believe win10 only has 32-bit x86 emulation for ARM processors. That could produce a lot of wacky side effects since we only build for 64-bit. Honestly I'm shocked it works at all.

We have plans to add native ARM builds for Windows but we're blocked right now until GitHub GAs their runners (see #928)

esimkowitz avatar Dec 05 '24 18:12 esimkowitz

Question - Why is this being marked as need more info? What additional information is required?

Printoiid avatar Dec 06 '24 01:12 Printoiid

I mismarked the architecture version for this bug when originally posting it - I've updated it accordingly to x64.

Printoiid avatar Dec 06 '24 01:12 Printoiid

was marked needs more info because of the arm64 confusion, thanks for correcting this

esimkowitz avatar Dec 06 '24 01:12 esimkowitz

I think we've tracked down the issue, should be fixed in the latest beta (0.10.0-beta.1), could you give it a try @Lizardbutt?

esimkowitz avatar Dec 09 '24 18:12 esimkowitz

leaving open for now until we get confirmation that this is fixed

esimkowitz avatar Dec 09 '24 18:12 esimkowitz

I think we've tracked down the issue, should be fixed in the latest beta (0.10.0-beta.1), could you give it a try @Lizardbutt?

Have changes been pushed? My local copy is reporting there are zero updates available.

image

image

Printoiid avatar Dec 09 '24 21:12 Printoiid

Nevermind, I needed to edit my settings.json - I'm checking now.

Printoiid avatar Dec 09 '24 21:12 Printoiid

@esimkowitz functionality works as the original bug posted. Still does not work as intended 😞

image

Printoiid avatar Dec 09 '24 21:12 Printoiid

Hmm is there anything special about your system or your mouse? Are you running in a VM?

esimkowitz avatar Dec 09 '24 21:12 esimkowitz

Hmm is there anything special about your system or your mouse? Are you running in a VM?

No - There's nothing special about my system.

I'm using a Logitech G502 Hero, which shouldn't create any problems - The keyboard I'm using is a Sofle Choc with QMK firmware, I can affirm that there's nothing weird there as I'm not using tap dancing, or any kind of scripting in my profile; I'm not running in a VM either.

Printoiid avatar Dec 09 '24 22:12 Printoiid

How often does this happen? Is it every time you right-click you're unable to bring up the menu or is it less frequent? Do you notice any patterns for when it occurs? Also is it specifically themes that cause issues or is it all the context menu items?

esimkowitz avatar Dec 09 '24 23:12 esimkowitz

Also do you see anything unusual in your logs? You can find the log file at %LOCALUSERDATA%\waveterm\Data\waveapp.log

esimkowitz avatar Dec 09 '24 23:12 esimkowitz

Okay @Lizardbutt we think we've tracked this one down, and it seems so obvious in retrospect: #1493

We're cutting a new beta build now, I'll post here when it's published

esimkowitz avatar Dec 11 '24 19:12 esimkowitz

@Lizardbutt can you give this release a try and see if it fixes the issue for you? https://github.com/wavetermdev/waveterm/releases/tag/v0.10.0-beta.5

esimkowitz avatar Dec 11 '24 19:12 esimkowitz

I haven't heard back in a while, I believe this is resolved

esimkowitz avatar Dec 17 '24 02:12 esimkowitz

I've been inactive due to the holidays - I'm testing this now

Printoiid avatar Dec 17 '24 06:12 Printoiid

Issue seems to be fixed! I'll update if this happens again, thank you @esimkowitz !

Printoiid avatar Dec 17 '24 06:12 Printoiid