[Bug]: Notification banners appearing behind window controls when using Window Controls Overlay

[jpotter23]

Current Behavior

The Config Error button that appears when there is an error in the config files is being placed behind the title bar buttons for minimize, maximize, and close on Windows 11. This makes it very hard to click on as only the very edge of the button sticks out further than the minimize button:

Expected Behavior

The button should be moved to the left side of the title bar buttons or to another more convenient location in the window.

Steps To Reproduce

1. Install waveterm on Windows 11
2. Open any waveterm json config files and input a character that breaks syntax.
3. Save the broken syntax file.
4. Observer the Config Error button appear in the upper right corner.
5. Attempt to click on the Config Error button.

Wave Version

v0.9.0

Platform

Windows

OS Version/Distribution

Windows 11 - Version: 22H2 - build: 22621.4317

Architecture

x64

Anything else?

Awesome application, looking forward to its further development! ;)

Questionnaire

• [ ] I'm interested in fixing this myself but don't know where to start
• [ ] I would like to fix and I have a solution
• [ ] I don't have time to fix this right now, but maybe later

[jpotter23]

This also affects the update button:

[esimkowitz]

This is a known issue with our tab code refactoring, unfortunately the fix is a bit complicated so for now I'd recommend disabling the window controls overlay by setting window:nativetitlebar to true in the settings.json