Gal Ben David

I'm confused. I'm not familiar with the code but why don't we use Reader::seek here? Eventually, this drop implementation takes a lot of time when dealing with a lot of...

@mdsteele WDYT about adding `Seek` bound to `Reader`?

BTW what about calling `consume`?

WDYM? The same solution would work for any OS

https://stackoverflow.com/questions/13020308/how-to-fmt-printf-an-integer-with-thousands-comma/46811454 This stackoverflow post is full of examples. I would recommend using https://github.com/dustin/go-humanize

BTW, after fixing this bug I found another bug. Fixing this bug made `check_ws_vs_http_matching` failing. The test looks like this: ```rust let network_filter = NetworkFilter::parse("|ws://$domain=4shared.com", true).unwrap(); assert!(network_filter.matches(&request::Request::from_urls("ws://example.com", "4shared.com", "websocket").unwrap())); ```...

It raises another question. Now that I think about it, why do we even compare it against the `source_url` and not against the URL of the request? When the `request_url`...

If you need any help with fixing the bug, I'd be happy to help.

Thank you for your comment, @Vihaanmody21. TLDextract is a reliable library that performs well. Additionally, it supports a few more use-cases than this library. When we extract billions of domains...

I completely agree with your viewpoint. TLDExtract is an excellent library designed to extract domains from diverse sources and data formats, which is not within our scope to address. Regarding...