google test

[ibtaylor]

https://github.com/wavelab/wave_geometry/blob/c9dd47d193fa6df3b27e3c091864e2cffaff3e95/cmake/AddGTest.cmake#L7

since googletest 1.8.1, the target should be GTest::gtest, I believe. Unfortunately, the cmake (kitware) supplied module uses a different name.

https://github.com/wavelab/wave_geometry/blob/c9dd47d193fa6df3b27e3c091864e2cffaff3e95/cmake/WaveGeometryHelpers.cmake#L26 GTest::gtest_main here.

I think the thought of the googletest project is to supply gmock and gtest both under the GTest cmake namespace with proper transitive dependencies, which would be difficult for the cmake (kitware) module to provide.

[leokoppel]

Hi, thanks for the info.

Are you seeing an error? It looks like this change would affect pre-installed gtest libraries, which I don't currently test - PRs are appreciated. The recommended method is to use a googletest source package so that libgtest can be built alongside the project-under-test with the same compiler flags. (Thus maybe it would be a good idea to remove find_package(GTest) entirely?)