wave
wave copied to clipboard
go1.22 and k8s1.29 support
CARRY: #105 and #107 Ref: #138
This is an experimental PR to add some additional works to @mamccorm's work: https://github.com/wave-k8s/wave/issues/138#issuecomment-2014217942
- Use
go.mod
, deprecate - Bump go1.22
- Migrate functions to Kubernetes 1.29
- Make required changes in the Makefile(s)
-
controller-gen
-
manifests
-
install-kubebuilder-tools
-
- Fix compilation issues
-
go build cmd
-
go test -c ./...
-
make test
fails with some errors that I couldn't understand:
DaemonSet controller Suite When a DaemonSet is reconciled And it has the required annotation
Adds a finalizer to the DaemonSet
/Users/furkan/src/wave/pkg/controller/daemonset/daemonset_controller_test.go:194
E0322 17:13:06.038082 83906 controller.go:329] "msg"="Reconciler error" "error"="error updating instance default/example: no kind is registered for the type core.daemonset in scheme \"pkg/runtime/scheme.go:100\"" "controller"="daemonset-controller" "object"={"name"="example" "namespace"="default"} "namespace"="default" "name"="example" "reconcileID"="8ca16401-15a8-48b7-96f9-a2838acbc8d3"
W0322 17:13:41.053875 83906 reflector.go:462] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: watch of *v1.ConfigMap ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
W0322 17:13:41.054024 83906 reflector.go:462] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: watch of *v1.Secret ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
W0322 17:13:41.054255 83906 reflector.go:462] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: watch of *v1.DaemonSet ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
W0322 17:14:16.232143 83906 reflector.go:462] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: watch of *v1.ConfigMap ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
E0322 17:13:41.216844 83906 controller.go:329] "msg"="Reconciler error" "error"="error updating instance default/example: no kind is registered for the type core.daemonset in scheme \"pkg/runtime/scheme.go:100\"" "controller"="daemonset-controller" "object"={"name"="example" "namespace"="default"} "namespace"="default" "name"="example" "reconcileID"="7f645167-04a3-43ce-9d04-f583049b04e1"
So I'm stumped on this. Waiting your feedback on this.
/cc @starkers @toelke