Occasional null ref exception on run, causes ocean to not appear.

[andrew-sidereal]

Describe the bug Occasionally, I think it's usually after changing a game object other than anything related to Crest, then running, I get a null reference exception and the ocean doesn't appear. Here's a screenshot: https://i.imgur.com/h7Z21jN.png

Due to the intermittent behavior, I'm guessing it's a race condition. As it seems to happen after editing other game object properties in a significant way, perhaps it has to do with those changes processing taking longer than Crest expects? I'm shooting in the dark here, just trying to provide some ideas.

in-editor, 2019.4.4, built-in pipeline

[daleeidd]

Thank you for reporting. Is domain or scene reloading disabled?

[andrew-sidereal]

How do I check that?

On Fri, Oct 23, 2020, 6:59 PM daleeidd [email protected] wrote:

Thank you for reporting. Is domain or scene reloading disabled?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crest-ocean/crest/issues/673#issuecomment-715624291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMSZ2UDAH3L77ZBUOPI323SMIDENANCNFSM4S44Q3ZA .

[daleeidd]

Should be near the bottom under Project Settings > Editor

[huwb]

What is the error btw?

Would it be possible to get the screenshot embedded in the issue so it's easy to view and captured here? Getting to the image on imgur from my mobile is arduous.

[daleeidd]

@huwb I've updated the post embedded screenshot.

@andrew-sidereal the other thing to ask is how old your Crest is? There is a chance we have already handled this one.

[huwb]

I received a support email from someone reporting CollisionProvider is null which is throwing exceptions, in Crest HDRP. I've asked for the circumstances around when it happens.

Above it says just misc editing of game objects - I'm not sure why that would cause this to happen. @andrew-sidereal if you're able to shed more light on this let us know.

The fallback solution could be to add a bunch of null guards but that may mask a deeper problem.

[WirrawaySoftware]

I get this error if I try to run the game while the prefab editor is open - closing the prefab editor before hitting play seems to avoid the problem.

[daleeidd]

I get this error if I try to run the game while the prefab editor is open - closing the prefab editor before hitting play seems to avoid the problem.

Thanks. It does appear to be likely the problem. It looks like we will need to support multiple camera to properly support this.