js-shapefile-to-geojson icon indicating copy to clipboard operation
js-shapefile-to-geojson copied to clipboard

typo?

Open veetrp opened this issue 8 years ago • 0 comments

Hi, this is good stuff.

For the nitpickers among us: In the file shapefile.js on line 19 it shows: t.data = e.date. I was wondering if this is a typo and should read e.data...? I changed it and it didn't seem to hurt.

Other question: I appreciate this works asynchronously. For small files it would be nice to do it synchronously. You would be able to return shp = new Shapefile(shpname,callback) with the shp.data object set. The code is quick enough to allow for that. Anyway, my two cents...

veetrp avatar Feb 10 '17 07:02 veetrp