js-shapefile-to-geojson icon indicating copy to clipboard operation
js-shapefile-to-geojson copied to clipboard

Published 20 hours ago • verified publisher icon wavded

no hardcoded paths please

Open barbalex opened this issue 11 years ago • 4 comments

My files or not in the root of the web-directory but in src/shapefile. In order to get it working I had to change the hardcoded paths in two locations:

  • shapefile.js, line 12: var path = (o.jsRoot || "") + "shapefile.js"
  • dbf.js, line 4: var worker = new Worker("dbf.js")

Thanks for this great tool! Alex

barbalex avatar Oct 24 '13 12:10 barbalex

thanks for reporting, I agree that should be fixed, care to propose a solution with PR?

wavded avatar Oct 24 '13 14:10 wavded

sorry, I'm a programming noob and I just barely managed to solve this issue by hardcoding my own paths...

2013/10/24 Marc Harter [email protected]

thanks for reporting, I agree that should be fixed, care to propose a solution with PR?

— Reply to this email directly or view it on GitHubhttps://github.com/wavded/js-shapefile-to-geojson/issues/13#issuecomment-26996309 .

barbalex avatar Oct 24 '13 14:10 barbalex

I ran into this same issue. Would be happy to propose a PR, but it seems the owner of this repo is no longer following up on PRs/issues. Do you need some help maintaining @wavded? Would you be willing to add others as maintainers?

kmanzana avatar Jan 10 '20 22:01 kmanzana

Feel free to submit a PR @kmanzana and I'll take a look. I would be willing to add maintainers.

wavded avatar Jan 12 '20 21:01 wavded